[libc-commits] [PATCH] D149923: [libc] Fix hanging test on NVPTX due to lack of warp sync

[Joseph Huber via Phabricator via libc-commits]

jhuber6 created this revision.
jhuber6 added a reviewer: tra.
Herald added subscribers: libc-commits, mattd, gchakrabarti, asavonic, ecnelises, tschuett.
Herald added projects: libc-project, All.
jhuber6 requested review of this revision.

Previously this wasn't implemented because it's effectively a no-op.
However, this should be safe to emit on sm_60 architectures. It's
important because it carries semantic importance for whether or not
something can be moved. So we should always emit this instrinsic.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149923

Files:
  libc/src/__support/GPU/nvptx/utils.h


Index: libc/src/__support/GPU/nvptx/utils.h
===================================================================
--- libc/src/__support/GPU/nvptx/utils.h
+++ libc/src/__support/GPU/nvptx/utils.h
@@ -130,11 +130,7 @@
 
 /// Waits for all threads in the warp to reconverge for independent scheduling.
 [[clang::convergent]] LIBC_INLINE void sync_lane(uint64_t mask) {
-#if __CUDA_ARCH__ >= 700
   __nvvm_bar_warp_sync(mask);
-#else
-  (void)mask;
-#endif
 }
 
 } // namespace gpu


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149923.519725.patch
Type: text/x-patch
Size: 477 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230505/b0fb7f78/attachment.bin>