[libc-commits] [libc] 9d0258e - [libc] Remove support for atomic test due to failing on sm_60

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Thu May 4 12:33:15 PDT 2023


Author: Joseph Huber
Date: 2023-05-04T14:14:13-05:00
New Revision: 9d0258e3634cec005ceb00e1b664f2f93b2625d8

URL: https://github.com/llvm/llvm-project/commit/9d0258e3634cec005ceb00e1b664f2f93b2625d8
DIFF: https://github.com/llvm/llvm-project/commit/9d0258e3634cec005ceb00e1b664f2f93b2625d8.diff

LOG: [libc] Remove support for atomic test due to failing on sm_60

This test fails on sm_60 because of the atomics codegen. We test atomics
indirectly with the `rpc` so we still have coverage.

Differential Revision: https://reviews.llvm.org/D149887

Added: 
    

Modified: 
    libc/test/src/__support/CPP/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/test/src/__support/CPP/CMakeLists.txt b/libc/test/src/__support/CPP/CMakeLists.txt
index 577c281eccd3..28db8bdd5c87 100644
--- a/libc/test/src/__support/CPP/CMakeLists.txt
+++ b/libc/test/src/__support/CPP/CMakeLists.txt
@@ -51,15 +51,19 @@ add_libc_test(
     libc.src.__support.CPP.utility
 )
 
-add_libc_test(
-  atomic_test
-  SUITE
-    libc-cpp-utils-tests
-  SRCS
-    atomic_test.cpp
-  DEPENDS
-    libc.src.__support.CPP.atomic
-)
+
+# This test fails with invalid address space operations on sm_60
+if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
+  add_libc_test(
+    atomic_test
+    SUITE
+      libc-cpp-utils-tests
+    SRCS
+      atomic_test.cpp
+    DEPENDS
+      libc.src.__support.CPP.atomic
+  )
+endif()
 
 # This test fails with a segmentation fault on NVPTX.
 if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)


        


More information about the libc-commits mailing list