[libc-commits] [PATCH] D149887: [libc] Remove support for atomic test due to failing on sm_60

[Joseph Huber via Phabricator via libc-commits]

jhuber6 created this revision.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
jhuber6 requested review of this revision.

This test fails on sm_60 because of the atomics codegen. We test atomics
indirectly with the `rpc` so we still have coverage.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149887

Files:
  libc/test/src/__support/CPP/CMakeLists.txt


Index: libc/test/src/__support/CPP/CMakeLists.txt
===================================================================
--- libc/test/src/__support/CPP/CMakeLists.txt
+++ libc/test/src/__support/CPP/CMakeLists.txt
@@ -51,15 +51,19 @@
     libc.src.__support.CPP.utility
 )
 
-add_libc_test(
-  atomic_test
-  SUITE
-    libc-cpp-utils-tests
-  SRCS
-    atomic_test.cpp
-  DEPENDS
-    libc.src.__support.CPP.atomic
-)
+
+# This test fails with invalid address space operations on sm_60
+if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
+  add_libc_test(
+    atomic_test
+    SUITE
+      libc-cpp-utils-tests
+    SRCS
+      atomic_test.cpp
+    DEPENDS
+      libc.src.__support.CPP.atomic
+  )
+endif()
 
 # This test fails with a segmentation fault on NVPTX.
 if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149887.519595.patch
Type: text/x-patch
Size: 807 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230504/61db8a0a/attachment.bin>