[libc-commits] [PATCH] D149581: [libc] Change GPU startup and loader to use multiple kernels

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/startup/gpu/nvptx/start.cpp:71
+  // To finis the execution we invoke all the callbacks registered via 'atexit'
+  // and then exit with the appropriate return value.
+  __llvm_libc::exit(retval);
----------------
JonChesterfield wrote:
> Is there a missing call to libc::finalize() here?
That was only necessary for the weird "global barrier" hack I implemented. `exit` should be sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149581/new/

https://reviews.llvm.org/D149581