[libc-commits] [PATCH] D149793: [libc][rpc] Avoid leaking port in Server.h

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed May 3 15:23:17 PDT 2023


jhuber6 added a comment.

In D149793#4317086 <https://reviews.llvm.org/D149793#4317086>, @JonChesterfield wrote:

> I'm not totally confident on optimisation removing that branch or the associated boolean needed in port to keep it working sanely if the port is moved but maybe. I'm pretty phobic of branches on GPUs.

We'd need to check the IR. I don't think there's too much utility for just having it here since there's only a single port and we close it after the switch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149793/new/

https://reviews.llvm.org/D149793



More information about the libc-commits mailing list