[libc-commits] [PATCH] D148290: Support custom attributes in pthread_create

Noah Goldstein via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed May 3 14:51:04 PDT 2023


goldstein.w.n updated this revision to Diff 519264.
goldstein.w.n marked 7 inline comments as done.
goldstein.w.n added a comment.

1. Fix error check in `pthread_attr_get*` changes
2. Remove todos that have already been addressed
3. Use defaults from thread.h
4. Add back support for `stacksize == 0`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148290/new/

https://reviews.llvm.org/D148290

Files:
  libc/src/__support/threads/linux/thread.cpp
  libc/src/__support/threads/thread.h
  libc/src/pthread/CMakeLists.txt
  libc/src/pthread/pthread_attr_getstack.cpp
  libc/src/pthread/pthread_attr_init.cpp
  libc/src/pthread/pthread_attr_setstack.cpp
  libc/src/pthread/pthread_attr_setstacksize.cpp
  libc/src/pthread/pthread_create.cpp
  libc/src/threads/thrd_create.cpp
  libc/test/integration/src/__support/threads/thread_detach_test.cpp
  libc/test/integration/src/pthread/CMakeLists.txt
  libc/test/integration/src/pthread/pthread_create_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148290.519264.patch
Type: text/x-patch
Size: 31223 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230503/4d403b92/attachment-0001.bin>


More information about the libc-commits mailing list