[libc-commits] [PATCH] D149598: [libc] Support concurrent RPC port access on the GPU

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/src/__support/RPC/rpc.h:398
+  for (uint64_t index = 0; index < port_size; ++index) {
+    uint32_t in = inbox[index].load(cpp::MemoryOrder::RELAXED);
+    uint32_t out = outbox[index].load(cpp::MemoryOrder::RELAXED);
----------------
JonChesterfield wrote:
> Is all this a straight copy/paste from the above? Why are client/server open even different functions, they could be identical
They're slightly different. The client open function only works if the port is capable of sending data while the server only works if it's capable of receiving it. I could probably template that somehow, but I didn't see the need.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149598/new/

https://reviews.llvm.org/D149598