[libc-commits] [PATCH] D149745: [libc] Split out FPExceptMatcher from the FP utils

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed May 3 09:10:11 PDT 2023


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/test/src/CMakeLists.txt:30
+  else()
+    list(APPEND MATH_UNITTEST_LINK_LIBRARIES LibcFPTestHelpers LibcFPExceptionHelpers)
+  endif()
----------------
Instead of adding `LibcFPExceptionHelpers` here for all math tests, WDYT of adding to `LINK_LIBRARIES` of the two tests which actually use this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149745/new/

https://reviews.llvm.org/D149745



More information about the libc-commits mailing list