[libc-commits] [PATCH] D149683: [libc] Replace -nostdlib with -nolibc and -nostartfiles for hermetic test link.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

In D149683#4313423 <https://reviews.llvm.org/D149683#4313423>, @jhuber6 wrote:

> Does this also need to be applied to this?
>
>   foreach(lib LibcHermeticTest LibcHermeticTestMain)    
>     target_include_directories(${lib} PRIVATE ${LIBC_BUILD_DIR}/include)    
>     target_compile_options(${lib}    
>         PRIVATE ${LIBC_HERMETIC_TEST_COMPILE_OPTIONS} -ffreestanding -nostdlib -nostdlib++)    
>   endforeach()

Creating static/object libraries does not involve the linker so may be not required?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149683/new/

https://reviews.llvm.org/D149683