[libc-commits] [PATCH] D149656: [libc] Remove use of 'assert' from the string tests

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue May 2 08:32:47 PDT 2023


jhuber6 created this revision.
jhuber6 added reviewers: sivachandra, lntue, michaelrj, gchatelet.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
jhuber6 requested review of this revision.

Currently we use `assert` as a stand-in for the typical test assertions.
This is because these functions exist outside of the base test class so
we can't use the typical assertion methods. The presence of these
asserts makes it difficult to compile these tests in a standalone
format. This patch replaces the use of `assert` with a simple trap. I
did not add printing of the failed condition as it would pull in more
dependencies.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149656

Files:
  libc/test/src/string/bzero_test.cpp
  libc/test/src/string/memory_utils/memory_check_utils.h
  libc/test/src/string/memory_utils/op_tests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149656.518751.patch
Type: text/x-patch
Size: 5014 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230502/3eab6ae0/attachment-0001.bin>


More information about the libc-commits mailing list