[libc-commits] [PATCH] D147231: [libc] Adds string and TestLogger classes, use them in LibcTest

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Mar 30 12:32:07 PDT 2023


sivachandra added inline comments.


================
Comment at: libc/src/__support/CPP/string.h:29
+private:
+  char *Buffer = nullptr;
+  size_t Size = 0;
----------------
Forgot to mention: the code style should be `snake_case` for var names and function names including class/struct members.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147231/new/

https://reviews.llvm.org/D147231



More information about the libc-commits mailing list