[libc-commits] [PATCH] D146981: [libc] Fix longjmp's fake return in x86_64

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/test/src/setjmp/setjmp_test.cpp:36
+  int val = __llvm_libc::setjmp(env);
+  if (val == 0)
+    __llvm_libc::longjmp(env, val);
----------------
We should have some check to ensure that `longjmp` is indeed being called?


================
Comment at: libc/test/src/setjmp/setjmp_test.cpp:41
+}
\ No newline at end of file

----------------
Please fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146981/new/

https://reviews.llvm.org/D146981