[libc-commits] [PATCH] D146861: [libc] Enable integration tests targeting NVIDIA GPUs

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:517
+    ${fq_build_target_name}
+    # The NVIDIA 'nvlink' linker does not currently support static libraries.
+    $<$<NOT:$<BOOL:${LIBC_TARGET_ARCHITECTURE_IS_GPU}>>:${fq_target_name}.__libc__>
----------------
sivachandra wrote:
> What will the `add_library` listing on line 472 do in that case?
It'll create the library, the linker just can't use it. I wasn't sure if it was worth putting an if around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146861/new/

https://reviews.llvm.org/D146861