[libc-commits] [PATCH] D146865: [libc] Remove unused aarch64 sqrt and sqrtf implementations

Roland McGrath via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Mar 24 21:00:45 PDT 2023


mcgrathr created this revision.
mcgrathr added reviewers: lntue, abrachet.
Herald added subscribers: libc-commits, ecnelises, tschuett, kristof.beyls.
Herald added projects: libc-project, All.
mcgrathr requested review of this revision.

These files are not used because the generic sqrt and sqrtf
functions already go through internal layers that reach the
machine-specific internal implemenations.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146865

Files:
  libc/src/math/aarch64/sqrt.cpp
  libc/src/math/aarch64/sqrtf.cpp


Index: libc/src/math/aarch64/sqrtf.cpp
===================================================================
--- libc/src/math/aarch64/sqrtf.cpp
+++ /dev/null
@@ -1,20 +0,0 @@
-//===-- Implementation of the sqrtf function for aarch64 ------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-#include "src/math/sqrtf.h"
-#include "src/__support/common.h"
-
-namespace __llvm_libc {
-
-LLVM_LIBC_FUNCTION(float, sqrtf, (float x)) {
-  float y;
-  __asm__ __volatile__("fsqrt %s0, %s1\n\t" : "=w"(y) : "w"(x));
-  return y;
-}
-
-} // namespace __llvm_libc
Index: libc/src/math/aarch64/sqrt.cpp
===================================================================
--- libc/src/math/aarch64/sqrt.cpp
+++ /dev/null
@@ -1,20 +0,0 @@
-//===-- Implementation of the sqrt function for aarch64 -------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-#include "src/math/sqrt.h"
-#include "src/__support/common.h"
-
-namespace __llvm_libc {
-
-LLVM_LIBC_FUNCTION(double, sqrt, (double x)) {
-  double y;
-  __asm__ __volatile__("fsqrt %d0, %d1\n\t" : "=w"(y) : "w"(x));
-  return y;
-}
-
-} // namespace __llvm_libc


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146865.508278.patch
Type: text/x-patch
Size: 1631 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230325/ee21c8fb/attachment.bin>


More information about the libc-commits mailing list