[libc-commits] [PATCH] D146681: [libc] Add a loader utility for NVPTX architectures for testing

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/utils/gpu/loader/amdgpu/Loader.cpp:291
+  void *dev_argv = copy_argument_vector(argc, argv, allocator);
 
   // Allocate fine-grained memory on the host to hold the pointer array for the
----------------
JonChesterfield wrote:
> handle_error calls around these returned pointers?
Probably better than being lazy and waiting for it to segfault on the GPU like I do now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146681/new/

https://reviews.llvm.org/D146681