[libc-commits] [PATCH] D146681: [libc] Add a loader utility for NVPTX architectures for testing

[Johannes Doerfert via Phabricator via libc-commits]

jdoerfert added a comment.

Looks reasonable, one nit below. Let's give others a chance to comment too.



================
Comment at: libc/utils/gpu/loader/Loader.h:43-54
+  void *dev_envp = alloc(envc * sizeof(char *));
+
+  for (int i = 0; i < envc; ++i) {
+    size_t size = strlen(envp[i]) + 1;
+    void *dev_str = alloc(size);
+    // Load the host memory buffer with the pointer values of the newly
+    // allocated strings.
----------------
probably with a different fn name, but isn't this the same?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146681/new/

https://reviews.llvm.org/D146681