[libc-commits] [PATCH] D146551: [libc] Re-enable wctob with fixes

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Mar 21 11:15:17 PDT 2023


michaelrj created this revision.
michaelrj added a reviewer: sivachandra.
Herald added subscribers: libc-commits, mikhail.ramalho, ecnelises, tschuett.
Herald added projects: libc-project, All.
michaelrj requested review of this revision.

The stdio test failures were due to headers potentially not being built
in the correct order. This should set up the dependencies correctly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146551

Files:
  libc/config/linux/x86_64/entrypoints.txt
  libc/include/CMakeLists.txt
  libc/src/wchar/CMakeLists.txt


Index: libc/src/wchar/CMakeLists.txt
===================================================================
--- libc/src/wchar/CMakeLists.txt
+++ libc/src/wchar/CMakeLists.txt
@@ -7,5 +7,6 @@
     wctob.h
   DEPENDS 
     libc.include.stdio
+    libc.include.wchar
     libc.src.__support.wctype_utils
 )
Index: libc/include/CMakeLists.txt
===================================================================
--- libc/include/CMakeLists.txt
+++ libc/include/CMakeLists.txt
@@ -184,6 +184,7 @@
     .llvm-libc-macros.file_seek_macros
     .llvm-libc-macros.stdio_macros
     .llvm-libc-types.size_t
+    .llvm-libc-types.ssize_t
     .llvm-libc-types.FILE
     .llvm-libc-types.cookie_io_functions_t
 )
Index: libc/config/linux/x86_64/entrypoints.txt
===================================================================
--- libc/config/linux/x86_64/entrypoints.txt
+++ libc/config/linux/x86_64/entrypoints.txt
@@ -195,7 +195,7 @@
     libc.src.unistd.write
 
     # wchar.h entrypoints
-    # libc.src.wchar.wctob
+    libc.src.wchar.wctob
 )
 
 set(TARGET_LIBM_ENTRYPOINTS


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146551.507063.patch
Type: text/x-patch
Size: 1068 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230321/84dcc798/attachment.bin>


More information about the libc-commits mailing list