[libc-commits] [PATCH] D146343: [libc] Make string tests compatible with the Fuchsia build

Roland McGrath via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Mar 17 18:00:15 PDT 2023


mcgrathr created this revision.
mcgrathr added a reviewer: abrachet.
Herald added subscribers: libc-commits, mikhail.ramalho, ecnelises, tschuett.
Herald added projects: libc-project, All.
mcgrathr requested review of this revision.

Some test code was doing loose conversions caught by compiler
warnings in  the Fuchsia build.  This included duplicated code
in a few tests that was reconsolidated with the existing header
file copy of the same functions.

The MemoryMatcher abstraction presumes gtest-style matcher support,
which is not available in Fuchsia's zxtest library.  It's avoided
in favor of simpler memory-comparing assertions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146343

Files:
  libc/test/UnitTest/MemoryMatcher.h
  libc/test/src/string/bcopy_test.cpp
  libc/test/src/string/memmove_test.cpp
  libc/test/src/string/memory_utils/memory_check_utils.h
  libc/test/src/string/strsignal_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146343.506250.patch
Type: text/x-patch
Size: 5940 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230318/dfc56f46/attachment.bin>


More information about the libc-commits mailing list