[libc-commits] [PATCH] D146256: [libc] Enable integration tests targeting the GPU

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/test/integration/startup/gpu/args_test.cpp:1
+//===-- Loader test to check args to main ---------------------------------===//
+//
----------------
jhuber6 wrote:
> sivachandra wrote:
> > I suppose you are not using the linux one because you don't have `envp` on the gpu? Or, is it future work? Also, unrelated to this change, what about global contructor/destructor on the GPUs?
> I could copy the `env` over as well. Could do that in a follow-up patch
If you copy the `envp` over, will the env vars checks pass?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146256/new/

https://reviews.llvm.org/D146256