[libc-commits] [PATCH] D146256: [libc] Enable integration tests targeting the GPU

Tue Ly via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Mar 17 08:38:41 PDT 2023


lntue added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:415
   get_fq_target_name(${test_name} fq_target_name)
-  if(NOT (${LIBC_TARGET_OS} STREQUAL "linux"))
+  if(NOT (${LIBC_TARGET_OS} STREQUAL "linux") AND
+     NOT (${LIBC_TARGET_OS} STREQUAL "gpu"))
----------------
Nit: Maybe create a list for future extension like:
```
set(INTEGRATION_TARGETS linux gpu)
if (NOT (${LIBC_TARGET_OS} IN_LIST INTEGRATION_TARGETS))
...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146256/new/

https://reviews.llvm.org/D146256



More information about the libc-commits mailing list