[libc-commits] [PATCH] D146048: [libc][NFC] Clean up clang-tidy warnings for `src/__support` and `src/math`.

Wed Mar 15 15:35:10 PDT 2023

sivachandra accepted this revision.
sivachandra added inline comments.

================
Comment at: libc/.clang-tidy:23
     value:           UPPER_CASE
+  - key:             readability-identifier-naming.LocalConstantCase
+    value:           UPPER_CASE
----------------
lntue wrote:
> sivachandra wrote:
> > lntue wrote:
> > > sivachandra wrote:
> > > > I suppose that if you don't add these, then the `VariableCase` complains about `UPPER_CASE` names. But, once you add this `LocalConstantCase`, it complains about `const` function args also and so you have to add `LocalConstantIgnoredRegexp`?
> > > I didn't look at `VariableCase`.  I guess I could simplify this a bit by using `LocalConstantIngoredRegexp` to allow `UPPER_CASE`, and using `VariableCase` for `lower_case`.
> > We already have `VariableCase` above on line 13, no?
> Yes, that's why I removed `LocalConstantCase` and changed `LocalConstantIgnoredRegexp` to allow `UPPER_CASE` instead.
Ah, you mean't you did not "notice" `VariableCase`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146048/new/

https://reviews.llvm.org/D146048