[libc-commits] [PATCH] D146145: [libc] Enable spawn lib in riscv

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

LGTM with one comment.



================
Comment at: libc/src/spawn/linux/posix_spawn.cpp:21
+#ifdef SYS_clone
+#include <llvm-libc-macros/signal-macros.h> // For SIGCHLD
+#endif
----------------
You should include `<signal.h>` not the macro file unconditionally. So, no `ifdef`, just `#include <signal.h>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146145/new/

https://reviews.llvm.org/D146145