[libc-commits] [libc] 2869d31 - [libc] Enable integration tests when built with gcc.

Siva Chandra Reddy via libc-commits libc-commits at lists.llvm.org
Mon Mar 13 00:47:39 PDT 2023


Author: Siva Chandra Reddy
Date: 2023-03-13T07:47:00Z
New Revision: 2869d31a7ac1e4748d171711614e9a89dfc0f75a

URL: https://github.com/llvm/llvm-project/commit/2869d31a7ac1e4748d171711614e9a89dfc0f75a
DIFF: https://github.com/llvm/llvm-project/commit/2869d31a7ac1e4748d171711614e9a89dfc0f75a.diff

LOG: [libc] Enable integration tests when built with gcc.

Added: 
    

Modified: 
    libc/test/CMakeLists.txt
    libc/test/src/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/test/CMakeLists.txt b/libc/test/CMakeLists.txt
index c6c470c6d0411..fc9df9c670cb7 100644
--- a/libc/test/CMakeLists.txt
+++ b/libc/test/CMakeLists.txt
@@ -25,8 +25,8 @@ if(NOT LLVM_LIBC_FULL_BUILD)
   return()
 endif()
 
-if(NOT (${LIBC_TARGET_OS} STREQUAL "linux") OR CMAKE_COMPILER_IS_GNUCXX)
-  # Integration tests are currently only available for clang on linux.
+if(NOT ${LIBC_TARGET_OS} STREQUAL "linux")
+  # Integration tests are currently only available for linux.
   return()
 endif()
 add_subdirectory(integration)

diff  --git a/libc/test/src/CMakeLists.txt b/libc/test/src/CMakeLists.txt
index a9b788ca4e70a..87daefb7476ca 100644
--- a/libc/test/src/CMakeLists.txt
+++ b/libc/test/src/CMakeLists.txt
@@ -60,14 +60,12 @@ if(${LIBC_TARGET_OS} STREQUAL "linux")
   add_subdirectory(pthread)
 endif()
 
-if(LLVM_RUNTIMES_BUILD OR LIBC_HDRGEN_EXE OR CMAKE_COMPILER_IS_GNUCXX)
+if(LLVM_RUNTIMES_BUILD OR LIBC_HDRGEN_EXE)
   # The public API test below uses tablegen to generate the test
   # source file. Since tablegen is not available during a runtimes
   # build, we will skip the test.
   # If a 
diff erent libc-hdrgen binary is being used, then also we
   # skip the api-test as we cannot generate the test source file.
-  # Additionally, this is an integration test and those only work with clang
-  # for the moment.
   return()
 endif()
 


        


More information about the libc-commits mailing list