[libc-commits] [PATCH] D145839: WIP: [libc] update LibcTableGenUtil for LLVM_LINK_LLVM_DYLIB

[Stephen Neuendorffer via Phabricator via libc-commits]

stephenneuendorffer created this revision.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
stephenneuendorffer requested review of this revision.

This library is linked into libc-hdrgen, which is compiled with
DISABLE_LLVM_LINK_LLVM_DYLIB.  This option avoids linking with
libLLVM.so when LLVM_LINK_LLVM_DYLIB is specified.  Unfortunately,
this can cause wierd linkage errors where symbols are defined
multiple times, with one definition coming from static linkage
and another definition coming from libLLVM.so.  This is usually
apparent as a link error with options defined multiple times.

This patch adds DISABLE_LLVM_LINK_LLVM_DYLIB to this library, to
get consistent linkage of libc-hdrgen.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145839

Files:
  libc/utils/LibcTableGenUtil/CMakeLists.txt


Index: libc/utils/LibcTableGenUtil/CMakeLists.txt
===================================================================
--- libc/utils/LibcTableGenUtil/CMakeLists.txt
+++ libc/utils/LibcTableGenUtil/CMakeLists.txt
@@ -2,6 +2,7 @@
   LibcTableGenUtil
   APIIndexer.cpp
   APIIndexer.h
+  DISABLE_LLVM_LINK_LLVM_DYLIB
   LINK_COMPONENTS Support TableGen
 )
 target_include_directories(LibcTableGenUtil PUBLIC ${LIBC_SOURCE_DIR})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145839.504343.patch
Type: text/x-patch
Size: 425 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230311/436ca748/attachment.bin>