[libc-commits] [PATCH] D145670: [libc] Extend the linux thread implementation for riscv64.

[Mikhail Ramalho via Phabricator via libc-commits]

mikhail.ramalho accepted this revision.
mikhail.ramalho added a comment.
This revision is now accepted and ready to land.

LGTM.

Unrelated topic: I started to get some rounding mode errors this morning, are you seeing them too @sivachandra or is it just on my side?

  [ RUN      ] LlvmLibcRoundingModeTest.SetAndGet
  /home/mgadelha/llvm-project/libc/test/src/fenv/rounding_mode_test.cpp:30: FAILURE
        Expected: s
        Which is: -1
  To be equal to: 0
        Which is: 0
  /home/mgadelha/llvm-project/libc/test/src/fenv/rounding_mode_test.cpp:32: FAILURE
        Expected: rm
        Which is: 2
  To be equal to: FE_UPWARD
        Which is: 8
  /home/mgadelha/llvm-project/libc/test/src/fenv/rounding_mode_test.cpp:40: FAILURE
        Expected: s
        Which is: -1
  To be equal to: 0
        Which is: 0
  /home/mgadelha/llvm-project/libc/test/src/fenv/rounding_mode_test.cpp:42: FAILURE
        Expected: rm
        Which is: 1
  To be equal to: FE_TOWARDZERO
        Which is: 4
  [  FAILED  ] LlvmLibcRoundingModeTest.SetAndGet
  Ran 1 tests.  PASS: 0  FAIL: 1



  /home/mgadelha/llvm-project/libc/test/src/fenv/getenv_and_setenv_test.cpp:71: FAILURE
        Expected: rm
        Which is: 0
  To be equal to: FE_TONEAREST
        Which is: 2
  [  FAILED  ] LlvmLibcFenvTest.Set_FE_DFL_ENV
  Ran 2 tests.  PASS: 1  FAIL: 1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145670/new/

https://reviews.llvm.org/D145670