[libc-commits] [PATCH] D145191: [libc] move stdlib and stdio to new errno pattern

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Mar 2 15:58:30 PST 2023


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/__support/StringUtil/CMakeLists.txt:18
   .message_mapper
-  libc.include.errno
   libc.src.__support.CPP.span
----------------
Add the dep on `libc.src.errno.errno`.


================
Comment at: libc/src/__support/threads/linux/thread.cpp:18
 #include "src/__support/threads/linux/futex_word.h" // For FutexWordType
+#include "src/errno/libc_errno.h"                   // For error macros
 
----------------
A corresponding dep should be added?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145191/new/

https://reviews.llvm.org/D145191



More information about the libc-commits mailing list