[libc-commits] [PATCH] D145191: [libc] move stdlib and stdio to new errno pattern

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

A general comment: If a function is just using the symbolic error values like `EINVAL`, it can still include `<errno.h>` directly. Only those places where the `errno` is updated/read need to include `src/errno/errno.h` and depend on `libc.src.errno.errno`.



================
Comment at: libc/src/stdio/CMakeLists.txt:28
     libc.include.stdio
-    libc.include.errno
     libc.src.__support.File.file
----------------
I think you should add a new dep on `libc.src.errno.errno` for all of these targets?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145191/new/

https://reviews.llvm.org/D145191