[libc-commits] [libc] 803437d - [libc][obvious] Fix errno includes in unistd

Michael Jones via libc-commits libc-commits at lists.llvm.org
Thu Mar 2 14:05:01 PST 2023 

Author: Michael Jones
Date: 2023-03-02T14:04:53-08:00
New Revision: 803437db15e78ac89d46575e6b766a7440ea80b4

URL: https://github.com/llvm/llvm-project/commit/803437db15e78ac89d46575e6b766a7440ea80b4
DIFF: https://github.com/llvm/llvm-project/commit/803437db15e78ac89d46575e6b766a7440ea80b4.diff

LOG: [libc][obvious] Fix errno includes in unistd

Minor typo swapped quotes for angle brackets. This patch moves
everything to quotes.

Differential Revision: https://reviews.llvm.org/D145188

Added: 
    

Modified: 
    libc/src/unistd/linux/access.cpp
    libc/src/unistd/linux/chdir.cpp
    libc/src/unistd/linux/close.cpp
    libc/src/unistd/linux/dup.cpp
    libc/src/unistd/linux/dup2.cpp
    libc/src/unistd/linux/dup3.cpp
    libc/src/unistd/linux/execv.cpp
    libc/src/unistd/linux/execve.cpp
    libc/src/unistd/linux/fchdir.cpp
    libc/src/unistd/linux/fork.cpp
    libc/src/unistd/linux/fsync.cpp
    libc/src/unistd/linux/ftruncate.cpp
    libc/src/unistd/linux/getcwd.cpp
    libc/src/unistd/linux/isatty.cpp
    libc/src/unistd/linux/linkat.cpp
    libc/src/unistd/linux/pread.cpp
    libc/src/unistd/linux/pwrite.cpp
    libc/src/unistd/linux/read.cpp
    libc/src/unistd/linux/readlink.cpp
    libc/src/unistd/linux/readlinkat.cpp
    libc/src/unistd/linux/symlinkat.cpp
    libc/src/unistd/linux/syscall.cpp
    libc/src/unistd/linux/sysconf.cpp
    libc/src/unistd/linux/unlink.cpp

Removed: 
    


################################################################################
diff  --git a/libc/src/unistd/linux/access.cpp b/libc/src/unistd/linux/access.cpp
index d7ebd97074980..1b5321e7f2d58 100644
--- a/libc/src/unistd/linux/access.cpp
+++ b/libc/src/unistd/linux/access.cpp
@@ -11,8 +11,8 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
+#include "src/errno/libc_errno.h"
 #include <fcntl.h>
-#include <src/errno/libc_errno.h>
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/chdir.cpp b/libc/src/unistd/linux/chdir.cpp
index f30835b063c9d..3c868f66d0545 100644
--- a/libc/src/unistd/linux/chdir.cpp
+++ b/libc/src/unistd/linux/chdir.cpp
@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/close.cpp b/libc/src/unistd/linux/close.cpp
index 07850609b6964..e9351ee55b36e 100644
--- a/libc/src/unistd/linux/close.cpp
+++ b/libc/src/unistd/linux/close.cpp
@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/dup.cpp b/libc/src/unistd/linux/dup.cpp
index 63a4ed445eddd..4125d382ef230 100644
--- a/libc/src/unistd/linux/dup.cpp
+++ b/libc/src/unistd/linux/dup.cpp
@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/dup2.cpp b/libc/src/unistd/linux/dup2.cpp
index 229f2caa8a522..877ba10e70f7a 100644
--- a/libc/src/unistd/linux/dup2.cpp
+++ b/libc/src/unistd/linux/dup2.cpp
@@ -11,8 +11,8 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
+#include "src/errno/libc_errno.h"
 #include <fcntl.h>
-#include <src/errno/libc_errno.h>
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/dup3.cpp b/libc/src/unistd/linux/dup3.cpp
index c688fb7090616..129213b335f59 100644
--- a/libc/src/unistd/linux/dup3.cpp
+++ b/libc/src/unistd/linux/dup3.cpp
@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/execv.cpp b/libc/src/unistd/linux/execv.cpp
index 89d1c7504dfe9..82240673579cd 100644
--- a/libc/src/unistd/linux/execv.cpp
+++ b/libc/src/unistd/linux/execv.cpp
@@ -12,7 +12,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/execve.cpp b/libc/src/unistd/linux/execve.cpp
index 995e3fe4b7f70..6c8701a39ebe6 100644
--- a/libc/src/unistd/linux/execve.cpp
+++ b/libc/src/unistd/linux/execve.cpp
@@ -12,7 +12,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/fchdir.cpp b/libc/src/unistd/linux/fchdir.cpp
index fcdc0059d240f..1059d1c84ce0f 100644
--- a/libc/src/unistd/linux/fchdir.cpp
+++ b/libc/src/unistd/linux/fchdir.cpp
@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/fork.cpp b/libc/src/unistd/linux/fork.cpp
index 20fa0ee884186..92d19e253ea42 100644
--- a/libc/src/unistd/linux/fork.cpp
+++ b/libc/src/unistd/linux/fork.cpp
@@ -13,7 +13,7 @@
 #include "src/__support/threads/fork_callbacks.h"
 #include "src/__support/threads/thread.h" // For thread self object
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/fsync.cpp b/libc/src/unistd/linux/fsync.cpp
index 3c581e90ae7fe..dd9706598cc63 100644
--- a/libc/src/unistd/linux/fsync.cpp
+++ b/libc/src/unistd/linux/fsync.cpp
@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/ftruncate.cpp b/libc/src/unistd/linux/ftruncate.cpp
index c400827ad11b8..b1e170dd378c4 100644
--- a/libc/src/unistd/linux/ftruncate.cpp
+++ b/libc/src/unistd/linux/ftruncate.cpp
@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 #include <unistd.h>
 

diff  --git a/libc/src/unistd/linux/getcwd.cpp b/libc/src/unistd/linux/getcwd.cpp
index ea0cfd7aeba5a..904fedf5487c8 100644
--- a/libc/src/unistd/linux/getcwd.cpp
+++ b/libc/src/unistd/linux/getcwd.cpp
@@ -12,8 +12,8 @@
 #include "src/__support/common.h"
 #include "src/string/allocating_string_utils.h" // For strdup.
 
+#include "src/errno/libc_errno.h"
 #include <linux/limits.h> // This is safe to include without any name pollution.
-#include <src/errno/libc_errno.h>
 #include <stdlib.h>
 #include <sys/syscall.h> // For syscall numbers.
 

diff  --git a/libc/src/unistd/linux/isatty.cpp b/libc/src/unistd/linux/isatty.cpp
index 1bdaedc6b71a9..bd12b6dc5b0b6 100644
--- a/libc/src/unistd/linux/isatty.cpp
+++ b/libc/src/unistd/linux/isatty.cpp
@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/ioctl.h>   // For ioctl numbers.
 #include <sys/syscall.h> // For syscall numbers.
 

diff  --git a/libc/src/unistd/linux/linkat.cpp b/libc/src/unistd/linux/linkat.cpp
index d7271a178f93a..77816a34d0e4f 100644
--- a/libc/src/unistd/linux/linkat.cpp
+++ b/libc/src/unistd/linux/linkat.cpp
@@ -11,8 +11,8 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
+#include "src/errno/libc_errno.h"
 #include <fcntl.h>
-#include <src/errno/libc_errno.h>
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/pread.cpp b/libc/src/unistd/linux/pread.cpp
index adf7303cfcffd..d308e96fc22a5 100644
--- a/libc/src/unistd/linux/pread.cpp
+++ b/libc/src/unistd/linux/pread.cpp
@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/pwrite.cpp b/libc/src/unistd/linux/pwrite.cpp
index a18d7d565d2ec..71f287ae39275 100644
--- a/libc/src/unistd/linux/pwrite.cpp
+++ b/libc/src/unistd/linux/pwrite.cpp
@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/read.cpp b/libc/src/unistd/linux/read.cpp
index fc9100bacc66c..ccaeda50630b0 100644
--- a/libc/src/unistd/linux/read.cpp
+++ b/libc/src/unistd/linux/read.cpp
@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/readlink.cpp b/libc/src/unistd/linux/readlink.cpp
index ecd3feddbad9a..795be27add7c8 100644
--- a/libc/src/unistd/linux/readlink.cpp
+++ b/libc/src/unistd/linux/readlink.cpp
@@ -11,8 +11,8 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
+#include "src/errno/libc_errno.h"
 #include <fcntl.h>
-#include <src/errno/libc_errno.h>
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/readlinkat.cpp b/libc/src/unistd/linux/readlinkat.cpp
index 0cd84e3fe6024..2deb4e24656f3 100644
--- a/libc/src/unistd/linux/readlinkat.cpp
+++ b/libc/src/unistd/linux/readlinkat.cpp
@@ -11,8 +11,8 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
+#include "src/errno/libc_errno.h"
 #include <fcntl.h>
-#include <src/errno/libc_errno.h>
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/symlinkat.cpp b/libc/src/unistd/linux/symlinkat.cpp
index c101a6a95fd6a..9b03c17f1e311 100644
--- a/libc/src/unistd/linux/symlinkat.cpp
+++ b/libc/src/unistd/linux/symlinkat.cpp
@@ -11,8 +11,8 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
+#include "src/errno/libc_errno.h"
 #include <fcntl.h>
-#include <src/errno/libc_errno.h>
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/syscall.cpp b/libc/src/unistd/linux/syscall.cpp
index 3af4c8aa8c35c..e7f5b1514b7f7 100644
--- a/libc/src/unistd/linux/syscall.cpp
+++ b/libc/src/unistd/linux/syscall.cpp
@@ -11,7 +11,7 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
-#include <src/errno/libc_errno.h>
+#include "src/errno/libc_errno.h"
 #include <stdarg.h>
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/sysconf.cpp b/libc/src/unistd/linux/sysconf.cpp
index 4066ded587997..2816cb447c128 100644
--- a/libc/src/unistd/linux/sysconf.cpp
+++ b/libc/src/unistd/linux/sysconf.cpp
@@ -10,8 +10,8 @@
 
 #include "src/__support/common.h"
 
+#include "src/errno/libc_errno.h"
 #include <linux/param.h> // For EXEC_PAGESIZE.
-#include <src/errno/libc_errno.h>
 #include <unistd.h>
 
 namespace __llvm_libc {

diff  --git a/libc/src/unistd/linux/unlink.cpp b/libc/src/unistd/linux/unlink.cpp
index 62d16a417300d..cc74500299936 100644
--- a/libc/src/unistd/linux/unlink.cpp
+++ b/libc/src/unistd/linux/unlink.cpp
@@ -11,8 +11,8 @@
 #include "src/__support/OSUtil/syscall.h" // For internal syscall function.
 #include "src/__support/common.h"
 
+#include "src/errno/libc_errno.h"
 #include <fcntl.h>
-#include <src/errno/libc_errno.h>
 #include <sys/syscall.h> // For syscall numbers.
 
 namespace __llvm_libc {

More information about the libc-commits mailing list