[libc-commits] [PATCH] D145099: [libc] add basic Intel MacOS configuration

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/src/__support/FPUtil/FEnvImpl.h:26
+#elif defined(LIBC_TARGET_ARCH_IS_X86) && !defined(__APPLE__)
+#if defined(__APPLE__)
+// TODO: add darwin x86_64 fenv
----------------
The `!defined(__APPLE__)` above and this condition here are opposites? Irrespective, can we use a model like the `AARCH64` one?

```
#elif defined(LIBC_TARGET_ARCH_IS_X86)
#if defined(__APPLE__)
#error ...
#else
#include <x86_64/FEnvImpl.h>
#endif
#endif
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145099/new/

https://reviews.llvm.org/D145099