[libc-commits] [PATCH] D154260: [libc] Fix more inline definitions

Roland McGrath via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jun 30 14:13:50 PDT 2023


mcgrathr created this revision.
mcgrathr added reviewers: Caslyn, michaelrj, gchatelet.
Herald added projects: libc-project, All.
Herald added a subscriber: libc-commits.
mcgrathr requested review of this revision.

Fix a bunch more instances of incorrect use of the `static`
keyword and missing use of LIBC_INLINE and LIBC_INLINE_VAR
macros. Note that even forward declarations and generic template
declarations must follow the prescribed patterns for libc code so
that they match every definition, all template specializations.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154260

Files:
  libc/src/__support/CPP/optional.h
  libc/src/__support/CPP/span.h
  libc/src/__support/CPP/string_view.h
  libc/src/__support/CPP/type_traits.h
  libc/src/__support/StringUtil/tables/linux_extension_signals.h
  libc/src/__support/StringUtil/tables/linux_platform_errors.h
  libc/src/__support/StringUtil/tables/linux_platform_signals.h
  libc/src/__support/StringUtil/tables/minimal_platform_errors.h
  libc/src/__support/StringUtil/tables/minimal_platform_signals.h
  libc/src/__support/StringUtil/tables/posix_errors.h
  libc/src/__support/StringUtil/tables/posix_signals.h
  libc/src/__support/StringUtil/tables/signal_table.h
  libc/src/__support/StringUtil/tables/stdc_errors.h
  libc/src/__support/StringUtil/tables/stdc_signals.h
  libc/src/__support/UInt.h
  libc/src/__support/threads/linux/thread.cpp
  libc/src/stdio/printf_core/write_int_converter.h
  libc/src/string/memory_utils/op_aarch64.h
  libc/src/string/memory_utils/op_generic.h
  libc/src/string/memory_utils/op_x86.h
  libc/src/string/memory_utils/strcmp_implementations.h
  libc/src/string/memory_utils/strstr_implementations.h
  libc/src/string/memory_utils/utils.h
  libc/src/string/string_utils.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154260.536423.patch
Type: text/x-patch
Size: 47280 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230630/df1f3086/attachment-0001.bin>


More information about the libc-commits mailing list