[libc-commits] [PATCH] D154150: [libc] fix MPFR double-rounding problems in fuzz test

Tue Ly via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jun 30 08:49:08 PDT 2023


lntue added inline comments.


================
Comment at: libc/fuzzing/stdlib/strtofloat_fuzz.cpp:83
+  mpfr_t mpfr_float;
+  mpfr_init2(mpfr_float, FloatProperties<float>::MANTISSA_WIDTH + 1);
+
----------------
lntue wrote:
> These values are useful.  Maybe you could add them directly to `FloatProperties` , something like:
> `FloatProperties<T>::PRECISION` ?
They are also used in https://github.com/llvm/llvm-project/blob/main/libc/utils/MPFRWrapper/MPFRUtils.cpp#L33


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154150/new/

https://reviews.llvm.org/D154150



More information about the libc-commits mailing list