[libc-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

Hubert Tong via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jun 28 21:55:29 PDT 2023


hubert.reinterpretcast added a comment.

In D151567#4458232 <https://reviews.llvm.org/D151567#4458232>, @hubert.reinterpretcast wrote:

> @azhan92, please incorporate a revert of https://reviews.llvm.org/rG64ca650cf9f180cc0b68c0005639028084066e10. Since it is an `XFAIL`. once the problem is fixed, the test will end up being an "unexpected success" unless we remove the `XFAIL`.

@azhan92, I believe that the fix needs to be done at a lower level. Currently, we are addressing one case (in `expandResponseFiles`). That does not address other cases where the ability to open directories for reading on AIX causes unexpected behaviour for LLVM.

We should go deeper to see where the `EISDIR` error originates (likely "below" the `expandResponseFile` call) on other platforms.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151567/new/

https://reviews.llvm.org/D151567



More information about the libc-commits mailing list