[libc-commits] [PATCH] D148717: [libc] Improve memcmp latency and codegen

Dávid Bolvanský via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jun 28 07:19:49 PDT 2023


xbolva00 added inline comments.


================
Comment at: libc/src/string/memory_utils/utils.h:194
+  // (e.g., int8_t ∈ [-128, 127]) returning 'INT_MIN' would break such code as
+  // `-INT_MIN` is not representable as an int32_t.
+
----------------
So they have UB in their codebases. They should really fix instead of workarounds like this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148717/new/

https://reviews.llvm.org/D148717



More information about the libc-commits mailing list