[libc-commits] [PATCH] D153683: [libc][math] Implement erff function correctly rounded to all rounding modes.

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.

overall LGTM with a nit.



================
Comment at: libc/test/src/math/erff_test.cpp:76
+      ++count;
+      // ASSERT_MPFR_MATCH(mpfr::Operation::erff, x, result, 0.5);
+      if (!TEST_MPFR_MATCH_ROUNDING_SILENTLY(mpfr::Operation::Erf, x, result,
----------------
does this still need to be here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153683/new/

https://reviews.llvm.org/D153683