[libc-commits] [PATCH] D153637: [libc] Fix installing GPU headers

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/CMakeLists.txt:90
+  set(LIBC_INSTALL_INCLUDE_DIR ${CMAKE_INSTALL_INCLUDEDIR}/gpu-none-llvm)
+  set(LIBC_LIBRARY_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}/gnu-none-llvm)
+elseif(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND LIBC_ENABLE_USE_BY_CLANG)
----------------
phosek wrote:
> Should this also be changed to `${CMAKE_BINARY_DIR}/lib`? I'd expect for either both `LLVM_BINARY_DIR` and `LLVM_LIBRARY_OUTPUT_INTDIR` to be defined, or neither.
I think previously it was the one with the host triple, but it should probably just go under `/lib` since we call it `libcgpu.a`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153637/new/

https://reviews.llvm.org/D153637