[libc-commits] [PATCH] D153594: [libc] Instantiate and sanity check rpc class

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Jun 22 16:11:08 PDT 2023


jhuber6 added reviewers: sivachandra, lntue.
jhuber6 added a comment.

The CMake looks good, losing protected is fine since these are pretty harmless methods. This will run on x64 as it stands, so you should try a non-GPU build of `libc` and see if it still runs and passes.

I had a previous attempt to move the `integration` tests to the same location but the unit test suite dos not handle multiple threads gracefully.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153594/new/

https://reviews.llvm.org/D153594



More information about the libc-commits mailing list