[libc-commits] [PATCH] D153581: [libc] Can build amdgpu libc even if rocm is missing

[Joseph Huber via Phabricator via libc-commits]

jhuber6 accepted this revision.
jhuber6 added a comment.
This revision is now accepted and ready to land.

LG after addressing comments.

Never caught this because if you can build the tests you presumably had HSA. But we definitely don't want vendor libraries for these builds, thanks.



================
Comment at: libc/cmake/modules/LLVMLibCObjectRules.cmake:154
         list(APPEND compile_options "-mcpu=${gpu_arch}")
+        list(APPEND compile_options "-nogpulib")
       elseif("${gpu_arch}" IN_LIST all_nvptx_architectures)
----------------
Redundant.


================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:578
   list(APPEND LIBC_HERMETIC_TEST_COMPILE_OPTIONS
        ${nvptx_options} -fno-use-cxa-atexit --target=${LIBC_GPU_TARGET_TRIPLE})
 endif()
----------------
Add here as well for NVPTX.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153581/new/

https://reviews.llvm.org/D153581