[libc-commits] [PATCH] D153571: [libc] Add memory fences to device-local locking calls

Jon Chesterfield via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Jun 22 09:44:45 PDT 2023


JonChesterfield added inline comments.


================
Comment at: libc/src/__support/RPC/rpc.h:531
     uint64_t lane_mask = gpu::get_lane_mask();
-    // Attempt to acquire the lock on this index.
     if (!this->try_lock(lane_mask, index))
----------------
jhuber6 wrote:
> Why was this removed
Writing the comment out twice seems excessive. This makes this code match the copy&paste in the other class too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153571/new/

https://reviews.llvm.org/D153571



More information about the libc-commits mailing list