[libc-commits] [PATCH] D153388: [libc] Add basic utility support for timing functions on the GPU

[Matt Arsenault via Phabricator via libc-commits]

arsenm added inline comments.


================
Comment at: libc/src/__support/GPU/amdgpu/utils.h:167
+  else if constexpr (LIBC_HAS_BUILTIN(__builtin_amdgcn_s_memtime))
+    return __builtin_amdgcn_s_memfixed_frequrency_clock();
+  else
----------------
__builtin_amdgcn_s_memfixed_frequrency_clock doesn't exist, and is a typo. If we want to introduce a new readcyclecounter alternative it should be a fully generic intrinsic like readcyclecounter


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153388/new/

https://reviews.llvm.org/D153388