[libc-commits] [PATCH] D153388: [libc] Add basic utility support for timing functions on the GPU

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added a comment.

In D153388#4437661 <https://reviews.llvm.org/D153388#4437661>, @JonChesterfield wrote:

> Test could be C to IR I think, check the ASM comes out for ptx and that some known architectures pick the right value for gcn. 
>  I'm not sure we can do much with the generic case.

And IR test wouldn't fit in `libc`, that'd probably be more of a `clang` thing to check that we specify the built-ins properly.

In D153388#4437695 <https://reviews.llvm.org/D153388#4437695>, @JonChesterfield wrote:

> @arsenm what do you think of adding a built-in that expands to one of the above? This sort of "try to get the time" isn't libc specific and the switch over different builtins is basically architecture mess that ideally wouldn't get reimplemented in lot of different library code.

It would definitely allow us to remove another cause of divergence for codes that want to be more generic w.r.t. the architecture, but they do slightly different things.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153388/new/

https://reviews.llvm.org/D153388