[libc-commits] [PATCH] D153395: Populating 'libmgpu.a' for math on the GPU

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jun 21 06:31:39 PDT 2023


jhuber6 added a comment.

In D153395#4436706 <https://reviews.llvm.org/D153395#4436706>, @jdoerfert wrote:

> I don't think we should, at least not by default. It would be very surprising, IMHO.

Agreed, I think having these default to a linker failure is a good way to state that it's not supported. IIRC CUDA's `nvcc` gives you warnings if you use a long double since it's just a double. So, please remove the long double variants from this patch for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153395/new/

https://reviews.llvm.org/D153395



More information about the libc-commits mailing list