[libc-commits] [PATCH] D153388: [libc] Add basic utility support for timing functions on the GPU

[Jon Chesterfield via Phabricator via libc-commits]

JonChesterfield added a comment.

It's not obvious to me that this is a good thing overall.

First off benchmarking is difficult to do meaningfully and adding easy to access timing functions makes it more likely that they'll be used to make superficial comparisons when changing implementations.

Secondly picking timers that run at different frequencies on different hardware will interact badly with people comparing performance between different machines.

What's the benefit side to this like?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153388/new/

https://reviews.llvm.org/D153388