[libc-commits] [PATCH] D153377: [libc] Make close function of the internal File class cleanup the file object.

Tue Ly via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Jun 20 16:05:55 PDT 2023


lntue accepted this revision.
lntue added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/__support/File/file.h:242-244
+    if (result != 0)
+      return result;
+    return 0;
----------------
Aren't these equivalent to `return result;`?  So I think you can simply change it to:
```
  return platform_close(this);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153377/new/

https://reviews.llvm.org/D153377



More information about the libc-commits mailing list