[libc-commits] [libc] ee6ace2 - [libc] Remove disabled pass after performance improvement

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Tue Jun 20 13:48:08 PDT 2023


Author: Joseph Huber
Date: 2023-06-20T15:48:02-05:00
New Revision: ee6ace27e0f2745f778f59b3f93d9a19cbfd2b01

URL: https://github.com/llvm/llvm-project/commit/ee6ace27e0f2745f778f59b3f93d9a19cbfd2b01
DIFF: https://github.com/llvm/llvm-project/commit/ee6ace27e0f2745f778f59b3f93d9a19cbfd2b01.diff

LOG: [libc] Remove disabled pass after performance improvement

This pass used to cause huge compile time regressions, That has been
address and can now be re-added.

Differential Revision: https://reviews.llvm.org/D153374

Added: 
    

Modified: 
    libc/startup/gpu/amdgpu/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/startup/gpu/amdgpu/CMakeLists.txt b/libc/startup/gpu/amdgpu/CMakeLists.txt
index b54dc377a629b..e7c0aeafafd9a 100644
--- a/libc/startup/gpu/amdgpu/CMakeLists.txt
+++ b/libc/startup/gpu/amdgpu/CMakeLists.txt
@@ -26,7 +26,4 @@ target_link_libraries(
   "--target=${LIBC_GPU_TARGET_TRIPLE}"
   "-flto"
   "-Wl,-mllvm,-amdgpu-lower-global-ctor-dtor=0"
-  # FIXME: This pass causes builds to take ~10x longer. Disable until the
-  # performance problems have been addressed.
-  "-Wl,-mllvm,-amdgpu-atomic-optimizations=0"
 )


        


More information about the libc-commits mailing list