[libc-commits] [PATCH] D153157: [libc] Add an option to use a job pool for GPU tests

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jun 16 11:28:46 PDT 2023


jhuber6 added a comment.

In D153157#4428981 <https://reviews.llvm.org/D153157#4428981>, @tra wrote:

> LGTM.
>
> Just a FYI -- in the past, running too many tests in parallel caused some tests to hang. I've empirically settled on `- j4` on cuda bots. Things may have improved in recent CUDA and driver versions, but I didn't push parallel tests further.

I've only had CUDA hang on me once in about 500 runs of the test suite due to parallelism, the AMD however stack fails about every other run. This should hopefully allow us to build in parallel, ever since I enabled the string conversion functions the test times have become more unreasonable. It may be worse on AMDGPU specifically because we run LTO on everything, but the `strtof` test alone takes about 44 seconds to build and run on my machine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153157/new/

https://reviews.llvm.org/D153157



More information about the libc-commits mailing list