[libc-commits] [libc] 7e8b0c2 - [libc] Disable the strtod and strtold tests on NVPTX

[Joseph Huber via libc-commits]

Author: Joseph Huber
Date: 2023-06-15T13:29:42-05:00
New Revision: 7e8b0c27f2526d5ddc4540d44b13ffe4ba9f20a0

URL: https://github.com/llvm/llvm-project/commit/7e8b0c27f2526d5ddc4540d44b13ffe4ba9f20a0
DIFF: https://github.com/llvm/llvm-project/commit/7e8b0c27f2526d5ddc4540d44b13ffe4ba9f20a0.diff

LOG: [libc] Disable the strtod and strtold tests on NVPTX

These tests have a single line that fails with a value off-by-one, see
https://lab.llvm.org/buildbot/#/builders/46/builds/50055/steps/12/logs/stdio .
Disable these for now so we can figure out what the error is later.

Reviewed By: lntue

Differential Revision: https://reviews.llvm.org/D153056

Added: 
    

Modified: 
    libc/test/src/stdlib/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/test/src/stdlib/CMakeLists.txt b/libc/test/src/stdlib/CMakeLists.txt
index 73d3d6d1a6408..3516e0a6e12b5 100644
--- a/libc/test/src/stdlib/CMakeLists.txt
+++ b/libc/test/src/stdlib/CMakeLists.txt
@@ -54,17 +54,20 @@ add_libc_test(
     libc.src.stdlib.atoll
 )
 
-add_fp_unittest(
-  strtod_test
-  SUITE
-    libc-stdlib-tests
-  SRCS
-    strtod_test.cpp
-  DEPENDS
-    libc.src.errno.errno
-    libc.src.stdlib.strtod
-    libc.src.__support.FPUtil.fenv_impl
-)
+# This fails on NVPTX where the output value is one-off of the expected value.
+if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
+  add_fp_unittest(
+    strtod_test
+    SUITE
+      libc-stdlib-tests
+    SRCS
+      strtod_test.cpp
+    DEPENDS
+      libc.src.errno.errno
+      libc.src.stdlib.strtod
+      libc.src.__support.FPUtil.fenv_impl
+  )
+endif()
 
 add_fp_unittest(
   strtof_test
@@ -123,17 +126,20 @@ add_libc_test(
     .strtol_test_support
 )
 
-add_libc_test(
-  strtold_test
-  SUITE
-    libc-stdlib-tests
-  SRCS
-    strtold_test.cpp
-  DEPENDS
-    libc.src.errno.errno
-    libc.src.__support.uint128
-    libc.src.stdlib.strtold
-)
+# This fails on NVPTX where the output value is one-off of the expected value.
+if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
+  add_libc_test(
+    strtold_test
+    SUITE
+      libc-stdlib-tests
+    SRCS
+      strtold_test.cpp
+    DEPENDS
+      libc.src.errno.errno
+      libc.src.__support.uint128
+      libc.src.stdlib.strtold
+  )
+endif()
 
 add_libc_test(
   strtoll_test