[libc-commits] [PATCH] D153056: [libc] Disable the strtod and strtold tests on NVPTX

[Joseph Huber via Phabricator via libc-commits]

jhuber6 created this revision.
jhuber6 added reviewers: tra, lntue, sivachandra.
Herald added subscribers: libc-commits, mattd, gchakrabarti, asavonic.
Herald added projects: libc-project, All.
jhuber6 requested review of this revision.

These tests have a single line that fails with a value off-by-one, see
https://lab.llvm.org/buildbot/#/builders/46/builds/50055/steps/12/logs/stdio .
Disable these for now so we can figure out what the error is later.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153056

Files:
  libc/test/src/stdlib/CMakeLists.txt


Index: libc/test/src/stdlib/CMakeLists.txt
===================================================================
--- libc/test/src/stdlib/CMakeLists.txt
+++ libc/test/src/stdlib/CMakeLists.txt
@@ -54,17 +54,20 @@
     libc.src.stdlib.atoll
 )
 
-add_fp_unittest(
-  strtod_test
-  SUITE
-    libc-stdlib-tests
-  SRCS
-    strtod_test.cpp
-  DEPENDS
-    libc.src.errno.errno
-    libc.src.stdlib.strtod
-    libc.src.__support.FPUtil.fenv_impl
-)
+# This fails on NVPTX where the output value is one-off of the expected value.
+if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
+  add_fp_unittest(
+    strtod_test
+    SUITE
+      libc-stdlib-tests
+    SRCS
+      strtod_test.cpp
+    DEPENDS
+      libc.src.errno.errno
+      libc.src.stdlib.strtod
+      libc.src.__support.FPUtil.fenv_impl
+  )
+endif()
 
 add_fp_unittest(
   strtof_test
@@ -123,17 +126,20 @@
     .strtol_test_support
 )
 
-add_libc_test(
-  strtold_test
-  SUITE
-    libc-stdlib-tests
-  SRCS
-    strtold_test.cpp
-  DEPENDS
-    libc.src.errno.errno
-    libc.src.__support.uint128
-    libc.src.stdlib.strtold
-)
+# This fails on NVPTX where the output value is one-off of the expected value.
+if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
+  add_libc_test(
+    strtold_test
+    SUITE
+      libc-stdlib-tests
+    SRCS
+      strtold_test.cpp
+    DEPENDS
+      libc.src.errno.errno
+      libc.src.__support.uint128
+      libc.src.stdlib.strtold
+  )
+endif()
 
 add_libc_test(
   strtoll_test


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153056.531836.patch
Type: text/x-patch
Size: 1477 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230615/06b8a0ed/attachment-0001.bin>