[libc-commits] [PATCH] D152575: Added modf for NVPTX and AMDGPU targets to implement 'libmgpu.a' for math on the GPU

[Ethan Luis McDonough via Phabricator via libc-commits]

elmcdonough added a comment.

In D152575#4421826 <https://reviews.llvm.org/D152575#4421826>, @jhuber6 wrote:

> In D152575#4421820 <https://reviews.llvm.org/D152575#4421820>, @AntonRydahl wrote:
>
>> Should I include both the vendor and builtin functions in this patch?
>
> That's a good question, we'd probably like to have both if we'd like to perform some performance tests, but I'm not sure if that's a good reason to keep it in-tree if we have a suitable alternative. @sivachandra What do you think?

Do you reckon it would be good to keep the vendor definitions as a fallback if `LIBC_HAS_BUILTIN` doesn't return true?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152575/new/

https://reviews.llvm.org/D152575