[libc-commits] [PATCH] D152575: Added modf for NVPTX and AMDGPU targets to implement 'libmgpu.a' for math on the GPU

Anton Rydahl via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jun 14 09:58:00 PDT 2023


AntonRydahl added a comment.

In D152575#4420284 <https://reviews.llvm.org/D152575#4420284>, @sivachandra wrote:

> I would rather implement the functions added by this patch as builtin wrappers instead of vendor wrappers. See the `round` example in D152468 <https://reviews.llvm.org/D152468>.

Should I include both the vendor and builtin functions in this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152575/new/

https://reviews.llvm.org/D152575



More information about the libc-commits mailing list