[libc-commits] [PATCH] D152630: [libc] Enable custom logging in LibcTest

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jun 14 02:19:20 PDT 2023


gchatelet added inline comments.


================
Comment at: libc/test/UnitTest/TestLogger.cpp:69
+template TestLogger &TestLogger::operator<< <int32_t>(int32_t);
+template TestLogger &TestLogger::operator<< <int64_t>(int64_t);
 template TestLogger &TestLogger::operator<< <long long>(long long);
----------------
sivachandra wrote:
> Why should we use `[u]int<..>_t` types? Could it lead to duplicate declaration errors, for example if `int64_t == long long`?
You're right, thx for catching it. I've used the standard C types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152630/new/

https://reviews.llvm.org/D152630



More information about the libc-commits mailing list